bug#17794: 24.4.50; change in src/window.c breaks desktop mode

[lee]

After upgrading to the current git version, I'm finding that emacs
cannot restore the session that has been saved with desktop-mode.

Upon loading the saved desktop, I'm getting a backtrace:


Debugger entered--Lisp error: (error "`recenter'ing a window that does not 
display current-buffer.")
  recenter((4))
  org-overview()
  org-set-startup-visibility()
  org-mode()
  set-auto-mode-0(org-mode nil)
  #[0 
"\302\242\237\211\205.\211@\303!\204\304\305\"\210\202'\301\306\240\210\307\300\"\204'\310\311\312\"\210A\266\202\202\207"
 [nil (t) ((org-mode)) functionp message "Ignoring unknown mode `%s'" t 
set-auto-mode-0 throw nop nil] 5 "\n\n(fn)"]()
  funcall(#[0 
"\302\242\237\211\205.\211@\303!\204\304\305\"\210\202'\301\306\240\210\307\300\"\204'\310\311\312\"\210A\266\202\202\207"
 [nil (t) ((org-mode)) functionp message "Ignoring unknown mode `%s'" t 
set-auto-mode-0 throw nop nil] 5 "\n\n(fn)"])
  set-auto-mode()
  normal-mode(t)
  after-find-file(nil t)
  find-file-noselect-1(#<buffer edit-t-what.txt> "~/notizen/edit-t-what.txt" 
nil nil "~/notizen/edit-t-what.txt" (12884909126 38))
  find-file-noselect("[SOME /PATH/FILE]")
  desktop-restore-file-buffer("[SOME /PATH/FILE]" "[SOME FILE]" nil)
  #[0 "\f\236A\206\305\300\301\302#\207" ["[SOME /PATH/FILE]" "[SOME FILE]" 
nil desktop-buffer-major-mode desktop-buffer-mode-handlers 
desktop-restore-file-buffer] 4 "\n\n(fn)"]()
  funcall(#[0 "\f\236A\206\305\300\301\302#\207" ["[SOME /PATH/FILE]" "[SOME 
FILE]" nil desktop-buffer-major-mode desktop-buffer-mode-handlers 
desktop-restore-file-buffer] 4 "\n\n(fn)"])
  desktop-create-buffer(206 "[SOME /PATH/FILE]" "[SOME FILE]" org-mode 
(auto-fill-mode yas-minor-mode tags-mode) 17233 (21419 nil) nil nil 
((buffer-file-coding-system . iso-latin-1-unix) (overwrite-mode) 
(truncate-lines . t)))
  eval-buffer(#<buffer  *load*> nil "[/PATH/TO/DESKTOP-FILE/DESKTOP-FILE]" nil 
t)  ; Reading at buffer position 10647
  load-with-code-conversion("[/PATH/TO/DESKTOP-FILE/DESKTOP-FILE]" 
"[/PATH/TO/DESKTOP-FILE/DESKTOP-FILE]" t t)
  load("[/PATH/TO/DESKTOP-FILE/DESKTOP-FILE]" t t t)
  desktop-read()
  #[0 "\303\211\235\203\304\"\301\305!\210\210       \205\306 
\210\307\211\207" [command-line-args desktop-save-mode inhibit-startup-screen 
"--no-desktop" delete 0 desktop-read t] 4 "\n\n(fn)"]()
  run-hooks(after-init-hook)
  command-line()
  normal-top-level()


(I have replaced the actual file names with [SOME /PATH/FILE], [SOME
FILE] and [/PATH/TO/DESKTOP-FILE/DESKTOP-FILE].)

This happens when the first file listed in the desktop-file is loaded.
I tried both starting emacs in an xterm and with X11 frames, and in both
cases, I'm getting the error message.


In GNU Emacs 24.4.50.3 (x86_64-unknown-linux-gnu, X toolkit)
 of 2014-06-17 on yun.yagibdah.de
Configured using:
 `configure --without-gpm --without-toolkit-scroll-bars
 --with-x-toolkit=lucid --enable-link-time-optimization'

Configured features:
XAW3D XPM JPEG TIFF GIF PNG RSVG IMAGEMAGICK SOUND DBUS GSETTINGS NOTIFY
ACL LIBSELINUX GNUTLS LIBXML2 FREETYPE LIBOTF XFT ZLIB

Important settings:
  value of $LANG: en_GB.utf8
  locale-coding-system: utf-8-unix

Major mode: Debugger

Minor modes in effect:
  show-paren-mode: t
  desktop-save-mode: t
  global-auto-complete-mode: t
  yas-global-mode: t
  yas-minor-mode: t
  tooltip-mode: t
  electric-indent-mode: t
  mouse-wheel-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  auto-composition-mode: t
  auto-encryption-mode: t
  auto-compression-mode: t
  buffer-read-only: t
  size-indication-mode: t
  column-number-mode: t
  line-number-mode: t
  transient-mark-mode: t

Recent input:
ESC x r e p o r t b TAB DEL DEL DEL DEL DEL DEL TAB 
e p o TAB TAB r t - e TAB RET

Recent messages:
[...]

Load-path shadows:
None found.

Features:
(shadow sort flyspell ispell mail-extr emacsbug debug org-element
org-rmail org-mhe org-irc org-info org-gnus org-docview doc-view
jka-compr image-mode org-bibtex bibtex org-bbdb org-w3m org byte-opt
bytecomp byte-compile cconv advice org-macro org-footnote org-pcomplete
pcomplete org-list org-faces org-entities noutline outline org-version
ob-emacs-lisp ob ob-tangle org-src ob-ref ob-lob ob-table ob-keys ob-exp
ob-comint comint ansi-color ring ob-core ob-eval org-compat org-macs
org-loaddefs find-func cal-menu calendar cal-loaddefs nnir gnus-msg
gnus-art mm-uu mml2015 epg-config mm-view mml-smime smime password-cache
dig mailcap gnus-sum gnus-group gnus-undo gnus-start gnus-cloud nnimap
nnmail mail-source tls utf7 netrc nnoo parse-time gnus-spec gnus-int
gnus-range gnus-win message sendmail format-spec rfc822 mml mml-sec
mm-decode mm-bodies mm-encode mail-parse rfc2231 rfc2047 rfc2045
ietf-drums mailabbrev gmm-utils mailheader gnus gnus-ems nnheader
gnus-util mail-utils mm-util mail-prsvr wid-edit server two-column
time-date paren cus-start cus-load desktop frameset fvwm-mode lsl-mode
auto-complete-config auto-complete popup yasnippet help-fns derived
easy-mmode cl-macs edmacro kmacro help-mode easymenu cl gv cl-loaddefs
cl-lib dired boxquote rect tooltip electric uniquify ediff-hook vc-hooks
lisp-float-type mwheel x-win x-dnd tool-bar dnd fontset image regexp-opt
fringe tabulated-list newcomment lisp-mode prog-mode register page
menu-bar rfn-eshadow timer select scroll-bar mouse jit-lock font-lock
syntax facemenu font-core frame cham georgian utf-8-lang misc-lang
vietnamese tibetan thai tai-viet lao korean japanese hebrew greek
romanian slovak czech european ethiopic indian cyrillic chinese
case-table epa-hook jka-cmpr-hook help simple abbrev minibuffer nadvice
loaddefs button faces cus-face macroexp files text-properties overlay
sha1 md5 base64 format env code-pages mule custom widget
hashtable-print-readable backquote make-network-process dbusbind
gfilenotify dynamic-setting system-font-setting font-render-setting
x-toolkit x multi-tty emacs)

Memory information:
((conses 16 255812 13191)
 (symbols 48 35349 0)
 (miscs 40 274 452)
 (strings 32 64436 7484)
 (string-bytes 1 2019175)
 (vectors 16 23738)
 (vector-slots 8 518498 2716)
 (floats 8 349 289)
 (intervals 56 311 56)
 (buffers 960 15)
 (heap 1024 21062 1687))

-- 
Knowledge is volatile and fluid.  Software is power.