[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#30489: 26.0.91; [PATCH] Data associated with json-readtable-error no
From: |
Eli Zaretskii |
Subject: |
bug#30489: 26.0.91; [PATCH] Data associated with json-readtable-error not a list |
Date: |
Fri, 16 Mar 2018 16:07:01 +0200 |
> From: Noam Postavsky <npostavs@gmail.com>
> Cc: contovob@tcd.ie, 30489@debbugs.gnu.org
> Date: Fri, 16 Mar 2018 05:52:06 -0400
>
> >> > - `(cond ,@res (t (signal 'json-readtable-error ,char)))))
> >> > + `(cond ,@res (t (signal 'json-readtable-error ,(list char))))))
> >>
> >> > When signalling json-readtable-error, the macro json-readtable-dispatch
> >> > passes the unrecognised character as error data verbatim, rather than as
> >> > a list. Attached is a patch which fixes this.
> >>
> >> Should this be applied to emacs-26? It seems to fix a regression
> >> relative to Emacs 25 (where this error just had `nil' as the data) and
> >> the patch looks safe enough.
> >
> > What change(s) introduced the regression?
>
> [1: 9314e6c56e]: 2017-09-04 03:40:30 -0400
> Embed JSON readtable into json-read
>
> https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=9314e6c56e248a5060a6c125e2088c4fbffe123b
Thanks, then the patch in question is OK for the release branch.