[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#66288: 29.1; Performance regression using pipe for subprocess
From: |
Eli Zaretskii |
Subject: |
bug#66288: 29.1; Performance regression using pipe for subprocess |
Date: |
Thu, 05 Oct 2023 08:50:06 +0300 |
> Date: Thu, 5 Oct 2023 01:54:43 +0300
> Cc: gregory@heytings.org, gerd.moellmann@gmail.com, 66288@debbugs.gnu.org
> From: Dmitry Gutov <dmitry@gutov.dev>
>
> On 05/10/2023 01:49, Paul Eggert wrote:
> >> + fcntl (inchannel, F_SETPIPE_SZ, readmax);
> >
> > This call can fail if you aren't root and you exceed the system limit in
> > /proc/sys/fs/pipe-max-size. So I suggest that if this fnctl fails with
> > EPERM, trying it again after clipping to that limit.
>
> Perhaps we'd rather fail loudly, so the user is aware that their
> customized value cannot be applied.
Why not silently? The clip_to_bounds call can already silently change
the original request anyway.
- bug#66288: 29.1; Performance regression using pipe for subprocess, (continued)
- bug#66288: 29.1; Performance regression using pipe for subprocess, Eli Zaretskii, 2023/10/03
- bug#66288: 29.1; Performance regression using pipe for subprocess, Gregory Heytings, 2023/10/03
- bug#66288: 29.1; Performance regression using pipe for subprocess, Dmitry Gutov, 2023/10/03
- bug#66288: 29.1; Performance regression using pipe for subprocess, Chris Hanson, 2023/10/03
- bug#66288: 29.1; Performance regression using pipe for subprocess, Eli Zaretskii, 2023/10/04
- bug#66288: 29.1; Performance regression using pipe for subprocess, Gregory Heytings, 2023/10/04
- bug#66288: 29.1; Performance regression using pipe for subprocess, Dmitry Gutov, 2023/10/04
- bug#66288: 29.1; Performance regression using pipe for subprocess, Chris Hanson, 2023/10/04
- bug#66288: 29.1; Performance regression using pipe for subprocess, Paul Eggert, 2023/10/04
- bug#66288: 29.1; Performance regression using pipe for subprocess, Dmitry Gutov, 2023/10/04
- bug#66288: 29.1; Performance regression using pipe for subprocess,
Eli Zaretskii <=
- bug#66288: 29.1; Performance regression using pipe for subprocess, Dmitry Gutov, 2023/10/05
- bug#66288: 29.1; Performance regression using pipe for subprocess, Eli Zaretskii, 2023/10/06
- bug#66288: 29.1; Performance regression using pipe for subprocess, Eli Zaretskii, 2023/10/05
- bug#66288: 29.1; Performance regression using pipe for subprocess, Gerd Möllmann, 2023/10/04
- bug#66288: 29.1; Performance regression using pipe for subprocess, Eli Zaretskii, 2023/10/04
- bug#66288: 29.1; Performance regression using pipe for subprocess, Eli Zaretskii, 2023/10/03