bug#67658: filesets can’t open files from menu-bar when using ‘:tree’

[Eli Zaretskii]

> Cc: 67658@debbugs.gnu.org
> Date: Sat, 16 Dec 2023 13:33:17 +0200
> From: Eli Zaretskii <eliz@gnu.org>
> 
> > From: ". shynur" <one.last.kiss@outlook.com>
> > Date: Wed, 6 Dec 2023 11:17:41 +0000
> > 
> > Reproduce:
> > 
> >   PS D:/Tmp> dir 
> >   test.txt test.org
> >   PS D:/Tmp> runemacs.exe -Q
> >   
> >   (require 'filesets)
> >   (push `("Teest"
> >           . ((:tree ,default-directory ""))) filesets-data)
> >   (filesets-init)
> >   
> >   M-x eval-buffer 
> >   
> >   Click: Menu-Bar -> File -> Filesets -> 0 Teest -> Tree: d:/Tmp/
> >   
> > Then emacs just gave me an error:
> >   “filesets-files-under: Wrong type argument: stringp, nil”
> >   
> > I expected it to open all the files under that directory.
> > Am I missing something?
> 
> You are not missing anything, this has been broken since Emacs 28.1,
> where we installed a change which fixed "normal" invocation of
> filesets-open, but broke its invocations from the menu-bar menus.  The
> breakage was due to omitting from the fix to bug#976 the cautious 'if'
> clause in the original author's code.
> 
> This should be fixed now on the emacs-29 branch.

No further comments, so I presume the bug was fixed, and I'm closing
it.