[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#70260: [PATCH] Flymake support for rust-ts-mode (clippy-driver)
From: |
Randy Taylor |
Subject: |
bug#70260: [PATCH] Flymake support for rust-ts-mode (clippy-driver) |
Date: |
Tue, 09 Apr 2024 02:42:15 +0000 |
On Sunday, April 7th, 2024 at 20:26, Dmitry Gutov <dmitry@gutov.dev> wrote:
>
>
> Minor fix and a TODO comment for the "cargo clippy" case.
>
> On 07/04/2024 19:42, Dmitry Gutov wrote:
>
> > X-Debbugs-Cc: Randy Taylor dev@rjt.dev
> >
> > Hi Randy and others,
> >
> > Here's a patch adding rust-ts-mode <-> flymake-mode integration using
> > clippy.
> >
> > Feedback welcome.
Thanks for working on this.
I'm not really familiar with flymake integration, but this
looks good to me. I have a few nits below.
+(defcustom rust-ts-flymake-command '("clippy-driver" "-")
+ "The external tool that will be used to perform the syntax check.
^^^^^^^^^^^^^^^^
maybe just "the check"?
Or something similar, since more is being done than just syntax checking.
+This is a non empty list of strings, the checker tool possibly followed
^^^^^^^^^ ^
non-empty? A colon would work well here.
+(defvar rust-ts--flymake-proc nil)
Should this be defvar-local?
+ ;; Flymake
^
A period at the end would make me happy :).