bug-gnulib
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Bug-gnulib] Add strdup.h.


From: Bruno Haible
Subject: Re: [Bug-gnulib] Add strdup.h.
Date: Fri, 23 Jan 2004 12:26:41 +0100
User-agent: KMail/1.5

Simon Josefsson wrote:
> How about this version?

It's better, but still some nits:

- strdup.c should #include strdup.h, to check the interface.
- strdup.h doesn't need to #include <config.h>; this is usually done
  in the .c file that uses it.
- The comment in strdup.m4 should say
    # Prerequisites of lib/strdup.h and lib/strdup.c.
- The "Include:" section of modules/strdup should mention "strdup.h".
  This is for the documentation in MODULES.html.
- path-concat.c and user-spec.c should be updated to #include "strdup.h",
  and their modules should depend on 'strdup'.

Bruno





reply via email to

[Prev in Thread] Current Thread [Next in Thread]