bug-gnulib
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [bug-gnulib] gcc -Wall warning for minmax.h


From: Paul Eggert
Subject: Re: [bug-gnulib] gcc -Wall warning for minmax.h
Date: Fri, 13 May 2005 16:29:52 -0700
User-agent: Gnus/5.1006 (Gnus v5.10.6) Emacs/21.4 (gnu/linux)

Derek Price <address@hidden> writes:

> minmax was so nice and small, but would you be willing to add an m4 file
> which called AC_CHECK_HEADERS([sys/param.h]) and the following lines to
> the beginning of minmax.h?
>
> #ifdef HAVE_SYS_PARAM_H
> # include <sys/param.h>
> #endif

Better yet, why not have "configure" check whether <sys/param.h>
defines MIN and MAX, and include <sys/param.h> only if that's true?
Similarly for <limits.h>.  That way, minmax.h will include these other
files only on broken systems.

> I'll send the complete patch if you approve.

Could you please implement something along those lines?  Thanks.




reply via email to

[Prev in Thread] Current Thread [Next in Thread]