bug-gnulib
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

quotearg minor fix to pacify gcc -Wswitch-default


From: Paul Eggert
Subject: quotearg minor fix to pacify gcc -Wswitch-default
Date: Sun, 22 Jan 2006 00:51:35 -0800
User-agent: Gnus/5.1007 (Gnus v5.10.7) Emacs/21.4 (gnu/linux)

I installed this into gnulib (and coreutils) after a Bison installer
noted the issue.  I'm not a big fan of -Wswitch-default in general but
here the workaround is harmless.

2006-01-22  Paul Eggert  <address@hidden>

        * quotearg.c (quotearg_buffer_restyled): Add "default: break;"
        to pacify gcc -Wswitch-default.

--- quotearg.c  23 Sep 2005 04:15:13 -0000      1.47
+++ quotearg.c  22 Jan 2006 08:46:02 -0000      1.48
@@ -1,7 +1,7 @@
 /* quotearg.c - quote arguments for output
 
-   Copyright (C) 1998, 1999, 2000, 2001, 2002, 2004, 2005 Free Software
-   Foundation, Inc.
+   Copyright (C) 1998, 1999, 2000, 2001, 2002, 2004, 2005, 2006 Free
+   Software Foundation, Inc.
 
    This program is free software; you can redistribute it and/or modify
    it under the terms of the GNU General Public License as published by
@@ -307,6 +307,9 @@ quotearg_buffer_restyled (char *buffer, 
                    STORE ('\\');
                    STORE ('?');
                    break;
+
+                 default:
+                   break;
                  }
              break;
 
@@ -454,6 +457,9 @@ quotearg_buffer_restyled (char *buffer, 
                                case '[': case '\\': case '^':
                                case '`': case '|':
                                  goto use_shell_always_quoting_style;
+
+                               default:
+                                 break;
                                }
                          }
 




reply via email to

[Prev in Thread] Current Thread [Next in Thread]