bug-gnulib
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: socket.h


From: Simon Josefsson
Subject: Re: socket.h
Date: Tue, 24 Jan 2006 12:58:37 +0100
User-agent: Gnus/5.110004 (No Gnus v0.4) Emacs/22.0.50 (gnu/linux)

Jim Meyering <address@hidden> writes:

> Simon Josefsson <address@hidden> wrote:
>> For some reason, mingw32 uses non-POSIX names for shutdown's
> ...
>> --- socket_.h        09 Jan 2006 17:13:09 +0100      1.1
>> +++ socket_.h        19 Jan 2006 14:39:07 +0100
>> @@ -34,4 +34,15 @@
>> # include <ws2tcpip.h>
>> #endif
>>
>> +/* For shutdown(). */
>> +#if !defined(SHUT_RD) && defined (SD_RECEIVE)
>> +# define SHUT_RD SD_RECEIVE
>> +#endif
>> +#if !defined(SHUT_WR) && defined (SD_SEND)
>> +# define SHUT_WR 1
>> +#endif
>> +#if !defined(SHUT_RDWR) && defined (SD_BOTH)
>
> Hi Simon,
>
> Over the years, I've removed all unnecessary parentheses like the ones
> above from nearly every file in coreutils.  This might be religious, but
> I find that those parentheses provide no benefit.  Although coreutils
> doesn't use that module, it might be worthwhile to start following the
> same guideline in gnulib.
>
> Any objection to removing them?

No, please install them.  I agree.  I wish 'indent' could fix this
too.  Maybe it can?  Even if I agree many code writing ideas given
here, I forget them all the time.

> Index: lib/socket_.h
> ===================================================================
> RCS file: /sources/gnulib/gnulib/lib/socket_.h,v
> retrieving revision 1.2
> diff -u -p -r1.2 socket_.h
> --- lib/socket_.h     19 Jan 2006 13:45:37 -0000      1.2
> +++ lib/socket_.h     23 Jan 2006 22:44:24 -0000
> @@ -35,13 +35,13 @@
>  #endif
>  
>  /* For shutdown(). */
> -#if !defined(SHUT_RD) && defined (SD_RECEIVE)
> +#if !defined SHUT_RD && defined SD_RECEIVE
>  # define SHUT_RD SD_RECEIVE
>  #endif
> -#if !defined(SHUT_WR) && defined (SD_SEND)
> +#if !defined SHUT_WR && defined SD_SEND
>  # define SHUT_WR 1
>  #endif
> -#if !defined(SHUT_RDWR) && defined (SD_BOTH)
> +#if !defined SHUT_RDWR && defined SD_BOTH
>  # define SHUT_RDWR 2
>  #endif
>  




reply via email to

[Prev in Thread] Current Thread [Next in Thread]