[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: module 'fts-lgpl' not complete
From: |
Jim Meyering |
Subject: |
Re: module 'fts-lgpl' not complete |
Date: |
Wed, 25 Jan 2006 18:29:29 +0100 |
Bruno Haible <address@hidden> wrote:
> Building the module 'fts-lgpl' on Linux/glibc fails like this:
>
> gcc -DHAVE_CONFIG_H -I. -I/packages/megatestdir/fts-lgpl/lib -I.. -g -O2
> -c /packages/megatestdir/fts-lgpl/lib/fts.c
> /packages/megatestdir/fts-lgpl/lib/fts.c:75:20: lstat.h: No such file or
> directory
>
> The reason is that the 'lstat' module is GPL.
Hi Bruno,
> Jim, would you agree to put the 'lstat' module under LGPL if we cut its
> dependency from the 'xalloc' module?
Sounds reasonable.
> Actually, using allocsa instead of
> xmalloc will also speed it up. What do you think about these two alternative
> patches?
The first one looks ok, but just using malloc would be simpler.
IMHO, performance shouldn't be a concern here. This is a replacement
function to work around deficient systems, after all.
Regarding the second patch, I see no explanation for why it
makes such a fundamental change (not appending `.'?).