Re: base64.? going into rfc3548bis

[Eric Blake]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

According to Simon Josefsson on 3/24/2006 4:06 AM:
> FYI: The update of RFC 3548 will include lib/base64.?, so additional
> review of these two files would be appreciated.
> 
> See http://josefsson.org/base-encoding/draft-josefsson-rfc3548bis.txt
> for the document.

The document mentions in 8. that the base 16 alphabet is the standard hex
characters, but the test vectors in 10 show BASE16("f") as "GG" instead of
"66".  One of those two sections is therefore wrong.

In the comments to base64_encode_alloc,
s/\(memory allocation fail\),/\1ed,/ s/indicate/indicates/

Also, the comments state that on allocation failure, base64_encode_alloc
returns BASE64_LENGTH(inlen)+1, but the code only returns
BASE64_LENGTH(inlen).

Nit - line up the \ in the B64x macro definition.

isbase64 is not documented.

In the comments to base64_decode_alloc, s/contain/&s/
s/function return/&s/g


- --
Life is short - so eat dessert first!

Eric Blake             address@hidden
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.2.1 (Cygwin)
Comment: Public key at home.comcast.net/~ericblake/eblake.gpg
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFEI/fA84KuGfSFAYARAu5cAKCmn9NMySrx6WjuzkcgDRsNDcojOgCgmWbl
h9kxhmQctyjzKmE8bj7sT9U=
=uA6f
-----END PGP SIGNATURE-----