Re: base64.? going into rfc3548bis

[Simon Josefsson]

Eric Blake <address@hidden> writes:

> According to Simon Josefsson on 3/24/2006 7:12 AM:
>> Thank you for your careful review!
>
> No problem; glad I could help.
>
>>  
>> +/* Return true if CH is a character from the Base64 alphabet, and
>> +   false otherwise. */
>>  bool
>>  isbase64 (char ch)
>
> What about '='?  Isn't it part of the alphabet, yet isbase64('=') returns
> false?

No, '=' is padding and not part of the alphabet.  I've improved the
comment:

/* Return true if CH is a character from the Base64 alphabet, and
   false otherwise.  Note that '=' is padding and not considered to be
   part of the alphabet.  */

This is in particular important when non-alphabet characters in the
stream is not ignored; '=' must be considered a non-alphabet character
then.

Thanks,
Simon