Re: underscores in gnulib file names

[Eric Blake-1]

> In fact, I've just removed the underscores in __fpending.[ch]:
> 
> 2007-09-08  Jim Meyering  <address@hidden>
> 
>       Rename __fpending.c -> fpending.c and __fpending.h -> fpending.h
>       * lib/fpending.h: Rename from __fpending.h.

And in the process, broke builds for platforms that lack __fpending
(such as cygwin), since AC_REPLACE_FUNCS is a stickler about
__fpending.c existing in that case.  (I didn't notice it until now,
because I had been doing incremental builds where a stale
__fpending.o was still in place from before the rename).  Fixed
as follows:

2007-09-24  Eric Blake  <address@hidden>

        Revert fpending breakage from 2007-09-08.
        * m4/fpending.m4 (gl_FUNC_FPENDING): Don't require existence of
        __fpending.c.

From: Eric Blake <address@hidden>
Date: Mon, 24 Sep 2007 16:13:39 -0600
Subject: [PATCH] Revert fpending breakage from 2007-09-08.

* m4/fpending.m4 (gl_FUNC_FPENDING): Don't require existence of
__fpending.c.

Signed-off-by: Eric Blake <address@hidden>
---
 ChangeLog      |    6 ++++++
 m4/fpending.m4 |    8 +++++---
 2 files changed, 11 insertions(+), 3 deletions(-)

diff --git a/ChangeLog b/ChangeLog
index 1c0c1a7..b0d2299 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,9 @@
+2007-09-24  Eric Blake  <address@hidden>
+
+       Revert fpending breakage from 2007-09-08.
+       * m4/fpending.m4 (gl_FUNC_FPENDING): Don't require existence of
+       __fpending.c.
+
 2007-09-24  Jim Meyering  <address@hidden>
 
        filenamecat.c: Add a test.
diff --git a/m4/fpending.m4 b/m4/fpending.m4
index a073483..90ce87b 100644
--- a/m4/fpending.m4
+++ b/m4/fpending.m4
@@ -1,6 +1,7 @@
-#serial 10
+#serial 11
 
-# Copyright (C) 2000, 2001, 2004, 2005, 2006 Free Software Foundation, Inc.
+# Copyright (C) 2000, 2001, 2004, 2005, 2006, 2007 Free Software
+# Foundation, Inc.
 # This file is free software; the Free Software Foundation
 # gives unlimited permission to copy and/or distribute it,
 # with or without modifications, as long as this notice is preserved.
@@ -16,7 +17,7 @@ dnl we have to grub around in the FILE struct.
 AC_DEFUN([gl_FUNC_FPENDING],
 [
   AC_CHECK_HEADERS_ONCE(stdio_ext.h)
-  AC_REPLACE_FUNCS([__fpending])
+  AC_CHECK_FUNCS_ONCE([__fpending])
   fp_headers='
 #     include <stdio.h>
 #     if HAVE_STDIO_EXT_H
@@ -74,5 +75,6 @@ AC_DEFUN([gl_FUNC_FPENDING],
     AC_DEFINE_UNQUOTED(PENDING_OUTPUT_N_BYTES,
       $ac_cv_sys_pending_output_n_bytes,
       [the number of pending output bytes on stream `fp'])
+    AC_LIBOBJ([fpending])
   fi
 ])
-- 
1.5.3.2

-- 
View this message in context: 
http://www.nabble.com/underscores-in-gnulib-file-names-tf4393644.html#a12869740
Sent from the Gnulib mailing list archive at Nabble.com.