bug-gnulib
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] Remove useless "if" tests before free. Deprecate "free" modu


From: Bruno Haible
Subject: Re: [PATCH] Remove useless "if" tests before free. Deprecate "free" module.
Date: Sat, 1 Mar 2008 15:00:09 +0100
User-agent: KMail/1.5.4

Jim Meyering wrote:
> --- a/modules/free
> +++ b/modules/free
> @@ -1,5 +1,9 @@
>  Description:
>  Work around incompatibility on older systems where free (NULL) fails.
> +# Note: as of 2008, this module is no longer useful, since no
> +# "reasonable portability target" (which excludes SunOS4) system
> +# requires the wrapper.
> +# FIXME: mark as obsolescent

You can "implement" this FIXME by adding a paragraph to the module description:

  Notice:
  This module is obsolete.

gnulib-tool will then print, when the module is used:

  Notice from module free:
  This module is obsolete.

See modules/TEMPLATE-EXTENDED for the full set of possible sections in a
module file.

Note also that the 'Description' field does not support comments. Its entire
contents is copied into the MODULES.html file when that is generated. Therefore
normally the description is kept short. The user can refer to the complete
doc of the module through doc/gnulib.{info.html}.

> Here's a proposed patch

Fine with me.

Bruno





reply via email to

[Prev in Thread] Current Thread [Next in Thread]