bug-gnulib
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] mktime: correct setting of REPLACE_MKTIME


From: Bruno Haible
Subject: Re: [PATCH] mktime: correct setting of REPLACE_MKTIME
Date: Sat, 1 Aug 2009 11:03:26 +0200
User-agent: KMail/1.9.9

Hi Jim,

> Without this change, updating coreutils to use latest gnulib
> resulted in link errors due to lack of definition of rpl_mktime
> on systems like gnu/linux for which the replacement is not used.
...
> --- a/m4/mktime.m4
> +++ b/m4/mktime.m4
> @@ -221,6 +221,8 @@ AC_DEFUN([gl_FUNC_MKTIME],
>    if test $ac_cv_func_working_mktime = no; then
>      REPLACE_MKTIME=1
>      gl_PREREQ_MKTIME
> +  else
> +    REPLACE_MKTIME=0
>    fi
>  ])

You're right. I had not understood the GNULIB_PORTCHECK idiom, and
was not aware that coreutils is compiling with -DGNULIB_PORTCHECK.

Bruno




reply via email to

[Prev in Thread] Current Thread [Next in Thread]