bug-gnulib
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] top/maint.mk: improved regex parser used in update-NEWS-hash


From: Jim Meyering
Subject: Re: [PATCH] top/maint.mk: improved regex parser used in update-NEWS-hash
Date: Sat, 01 Aug 2009 13:31:13 +0200

Peter Simons wrote:
> The original version required a very specific spelling of the line:
>
>   old_NEWS_hash = foobar
>
> In particular, it didn't allow for \t to be used instead of blanks, and
> it didn't recognize the simply-expanded assignment operator ':='.
> ---
>  top/maint.mk |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/top/maint.mk b/top/maint.mk
> index 228b414..c3e2f47 100644
> --- a/top/maint.mk
> +++ b/top/maint.mk
> @@ -492,7 +492,7 @@ sc_immutable_NEWS:
>  # Update the hash stored above.  Do this after each release and
>  # for any corrections to old entries.
>  update-NEWS-hash: NEWS
> -     perl -pi -e 's/^(old_NEWS_hash = ).*/$${1}'"$(NEWS_hash)/" \
> +     perl -pi -e 's/^(old_NEWS_hash[ \t]+:?=[ \t]+).*/$${1}'"$(NEWS_hash)/" \

Thanks.  Pushed with adjusted log message,
i.e, to start with the "module-name: " and to use
ChangeLog-style "* dir/file (): ..." description.




reply via email to

[Prev in Thread] Current Thread [Next in Thread]