bug-gnulib
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] Exclude optimization


From: Bruno Haible
Subject: Re: [PATCH] Exclude optimization
Date: Tue, 11 Aug 2009 16:06:29 +0200
User-agent: KMail/1.9.9

Sergey Poznyakoff wrote:
> > I would like to see some unit tests committed to this module before the
> > big optimization.
> 
> Here they go:

This gives a lot of confidence. Thanks. One point, though: When running your
new tests against the former 'exclude' implementation, I get one failure:

PASS: test-exclude1.sh
PASS: test-exclude2.sh
PASS: test-exclude3.sh
PASS: test-exclude4.sh
PASS: test-exclude5.sh
PASS: test-exclude6.sh
*** excltmp     2009-08-11 16:00:26.000000000 +0200
--- excltmp.1   2009-08-11 16:00:26.000000000 +0200
***************
*** 1,2 ****
- bar: 1
  bar: 0
--- 1,2 ----
  bar: 0
+ bar: 1
FAIL: test-exclude7.sh

Has the precedence handling changed, or is the test checking undefined
behaviour?

Bruno




reply via email to

[Prev in Thread] Current Thread [Next in Thread]