bug-gnulib
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: update-copyright local hook


From: Eric Blake
Subject: Re: update-copyright local hook
Date: Sat, 15 Aug 2009 06:31:41 -0600
User-agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1.22) Gecko/20090605 Thunderbird/2.0.0.22 Mnenhy/0.7.6.666

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

According to Jim Meyering on 8/15/2009 2:37 AM:
>> It changed a bit due to the merge; here's what I'm pushing.

I haven't pushed yet, in case we decide something different...

> ...
>>      grep -l -w Copyright $$($(VC_LIST_EXCEPT))              \
>> -      | grep -v -E '$(update-copyright-exclude-regexp)'     \
>> +            $(srcdir)/ChangeLog | grep -v COPYING           \
>>        | $(update-copyright-env) xargs $(build_aux)/$@
> 
> Adding back in the top level ChangeLog file is good.
> Do you think we should try to add back any other ChangeLog files?

VC_LIST_EXCEPT is funny.  If .x-update-copyright does not exist, then all
ChangeLog files except the top level are excluded (and the post-processing
in update-copyright then excludes COPYING variants).  But if
.x-update-copyright exists, then all files not explicitly excluded are
candidates, including other ChangeLog files (so if you want to add files
but preserve the behavior of excluding rotated ChangeLogs, then
.x-update-copyright must explicitly list 'ChangeLog.').  About the only
way I can see to include all ChangeLog by default, but still honor the
file .x-update-copyright, is to inline the bulk of the VC_LIST_EXCEPT
macro directly in the update-copyright rule but without the ChangeLog
exception.

- --
Don't work too hard, make some time for fun as well!

Eric Blake             address@hidden
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (Cygwin)
Comment: Public key at home.comcast.net/~ericblake/eblake.gpg
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAkqGqq0ACgkQ84KuGfSFAYCV0gCfbvmaP5TUByrn39NiQEbL2iRP
40oAnidU0X9bB4c4U2EYnL3mCX0eMeta
=ppr1
-----END PGP SIGNATURE-----




reply via email to

[Prev in Thread] Current Thread [Next in Thread]