bug-gnulib
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] bootstrap: use a more consistent error reporting scheme.


From: Jim Meyering
Subject: Re: [PATCH] bootstrap: use a more consistent error reporting scheme.
Date: Fri, 06 Jul 2012 13:56:33 +0200

Akim Demaille wrote:
> Le 6 juil. 2012 à 12:01, Jim Meyering a écrit :
>
>> Akim Demaille wrote:
>>
>>> It is also very useful to have a single command that issues
>>> several lines.  This is the case here for instance:
>>
>> I would debate the "very useful" part ;-)
>> How about "might be nice, in the rare event someone sees this message"?
>
> Fair enough :)  It should have read "I have used this
> often in several scripts I maintain".
>
>> No change.  The existing code uses echo and prints it all on one line.
>> I think it's fine to leave it that way.
>> It's only a diagnostic, after all.
>
> Installed!

Um... this is a good reason to post an adjusted patch.
What I meant was that it is fine to continue to print that diagnostic
on one line, but not using echo; using the new "warn".

It should use warn, and warn should be defined as in init.sh.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]