[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: extern-inline: be -Wundef safe in config.h
|
From: |
Eric Blake |
|
Subject: |
Re: extern-inline: be -Wundef safe in config.h |
|
Date: |
Tue, 25 Sep 2012 08:06:09 -0600 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:15.0) Gecko/20120911 Thunderbird/15.0.1 |
On 09/25/2012 06:27 AM, Akim Demaille wrote:
> Recent changes introduce -Wundef warnings in config.h. The
> appended proposal eliminates them.
>
> -#if __GNUC__ ? __GNUC_STDC_INLINE__ : 199901L <= __STDC_VERSION__
> +#if (__GNUC__ \
Even though gcc's -Wundef will never warn about __GNUC__ being
undefined, it seems like you should also be checking that __GNUC__ is
defined for the sake of non-gcc compilers, if we accept this approach.
At any rate, while most of gnulib doesn't care about -Wundef, I can
agree to the concept of having config.h be -Wundef clean, so I'm okay
with this patch if Paul is.
--
Eric Blake address@hidden +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature