Re: strtok_r in windows

[Eric Blake]

On 10/04/2012 11:31 AM, Nikos Mavrogiannopoulos wrote:
> I received the following bug report for gnulib.
> http://savannah.gnu.org/support/?108150

Thanks for the heads up.  Adding Alexey, as reporter.

> 
> gnutls-3.1.2-winpthreads-strtok_r.patch
> 
> 
> --- gnutls-3.1.2/gl/string.in.h.orig  2012-04-13 00:05:11 +0400
> +++ gnutls-3.1.2/gl/string.in.h       2012-10-03 14:28:32 +0400
> @@ -683,7 +683,7 @@
>                    (char *restrict s, char const *restrict delim,
>                     char **restrict save_ptr));
>  # else
> -#  if @UNDEFINE_STRTOK_R@ || defined GNULIB_POSIXCHECK
> +#  if @UNDEFINE_STRTOK_R@ || defined GNULIB_POSIXCHECK || defined 
> __WINPTHREADS_VERSION

Unfortunately, I don't think this patch is quite right.  Rather, we
should be figuring out why UNDEFINE_STRTOK_R is not getting set
correctly when compiling with winpthreads.  That is, the correct patch
should live in m4/strtok_r.m4.

By the way, what does the winpthreads project #define strtok_r() as, and
why do they not also provide it as a function as required by POSIX?

-- 
Eric Blake   address@hidden    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

signature.asc
Description: OpenPGP digital signature