bug-gnulib
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: sig2str and str2sig use in C++


From: Paul Eggert
Subject: Re: sig2str and str2sig use in C++
Date: Mon, 10 Jun 2013 22:41:58 -0700
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130510 Thunderbird/17.0.6

On 06/10/2013 07:50 PM, Daniel J Sebald wrote:
> char sig_strings[] = {
> #ifdef SIGHUP
>   HUP_STRING, '\0',
> #endif

Yes, that's better, though it should look more like this:

char const sig_strings[] =
#define HUP_OFFSET 0
#ifdef SIGHUP
  "HUP" "\0"
# define INT_OFFSET (HUP_OFFSET + sizeof "HUP")
#else
# define INT_OFFSET HUP_OFFSET
#endif
#ifdef SIGINT
  "INT" "\0"
# define QUIT_OFFSET (INT_OFFSET + sizeof "INT")
#else
# define QUIT_OFFSET INT_OFFSET
#endif
#ifdef SIGQUIT
...
  ;

Maybe someone else can come up with something even better.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]