[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] userspec: support optional parameters to parse_user_spec()
|
From: |
Pádraig Brady |
|
Subject: |
Re: [PATCH] userspec: support optional parameters to parse_user_spec() |
|
Date: |
Sat, 21 Sep 2013 16:36:26 +0100 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130110 Thunderbird/17.0.2 |
Pushed with these additional tweaks:
diff --git a/lib/userspec.c b/lib/userspec.c
index 760b007..e115552 100644
--- a/lib/userspec.c
+++ b/lib/userspec.c
@@ -114,7 +114,7 @@ parse_with_separator (char const *spec, char const *separato
char const *g;
char *gname = NULL;
uid_t unum = *uid;
- gid_t gnum = gid ? *gid : 0;
+ gid_t gnum = gid ? *gid : -1;
error_msg = NULL;
if (username)
diff --git a/tests/test-userspec.c b/tests/test-userspec.c
index d6e0161..8e3672f 100644
--- a/tests/test-userspec.c
+++ b/tests/test-userspec.c
@@ -184,7 +184,6 @@ main (void)
/* Ensure NULL parameters are ignored. */
{
uid_t uid = (uid_t) -1;
- gid_t gid = (gid_t) -1;
char const *diag = parse_user_spec ("", &uid, NULL, NULL, NULL);
if (diag)
{
thanks,
Pádraig.