Re: [PATCH] use libcrypto routines in gnulib

[Pádraig Brady]

On 12/03/2013 06:24 AM, Paul Eggert wrote:
> Pádraig Brady wrote:
>> Seems the handiest way to do this is to do the following
>> in configure.ac before gl_INIT:
>>
>> dnl Enable use of libcrypto by default
>> AC_ARG_WITH([openssl],
>>   [AS_HELP_STRING([--with-openssl],
>>     [use libcrypto hash routines if available: default=yes])],
>>   [],
>>   [with_openssl=yes])
> 
> Unfortunately with Emacs this causes "configure --help" to output
> two disagreeing lines for --with-openssl; one incorrect
> one, put out by the AC_ARG_WITH in m4/gl-openssl.m4,
> and one correct one, put out by the above call.

Ugh, It's a pity one can't nicely override AC_ARG_WITH.
It seems that the first use of --with[out]-whatever
should take precedence.

I'll probably do this in coreutils configure.ac before gl_INIT,
so as to at least set the default as coreutils wants and caters for,
and allowing users to --without-openssl if they want.

dnl Enable use of libcrypto by default
AS_VAR_SET_IF([with_openssl], [], [with_openssl=maybe])

> Come to think of it, the GNU coding standards say that
> --with-openssl should configure the system to use the
> OpenSSL library (and fail if it's not available, presumably;
> that's what gl_GC and gl_LIBSELINUX do), but the recently-added
> code doesn't do that; it issues a warning and disables the
> library instead.  Maybe we should be more consistent with
> the rest of Gnulib here?

Hmm, I don't think the above mentioned fail if not available?
I'm using "maybe" above anyway, so that "yes" may be
treated like this in future.

thanks,
Pádraig.