[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] obstack: Remove ancient NeXTSTEP gcc support conditional
From: |
Will Newton |
Subject: |
Re: [PATCH] obstack: Remove ancient NeXTSTEP gcc support conditional |
Date: |
Thu, 27 Mar 2014 20:51:32 +0000 |
On 27 March 2014 20:45, Paul Eggert <address@hidden> wrote:
> On 03/27/2014 01:08 PM, Will Newton wrote:
>>
>> causes a warning with -Wundef which glibc
>> now enables by default. Rather than updating the conditional it seems
>> better to just remove it.
>
>
> If you don't mind I'd like to be a bit more conservative. glibc
> <sys/cdefs.h> says to use __extension__ only for GCC 2.8 or later, which is
> still pretty old but if the code's in cdefs.h it might as well be consistent
> in obstack.h. I pushed the attached patch.
Thanks, that looks fine. I wasn't sure which gcc versions were
supported as the README only mentions 2.95.
--
Will Newton
Toolchain Working Group, Linaro