[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: syntax-check rule 'sc_copyright_check' assumes "Free Software Founda
From: |
Pádraig Brady |
Subject: |
Re: syntax-check rule 'sc_copyright_check' assumes "Free Software Foundation" |
Date: |
Fri, 18 Apr 2014 19:41:01 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130110 Thunderbird/17.0.2 |
On 04/18/2014 06:46 PM, Assaf Gordon wrote:
> Hello,
>
> A minor nit-pick for GnuLib's "make syntax-check",
> where "maint.mk" has the following rule:
> ===
> sc_copyright_check:
> <...>
> @require='Copyright @copyright\{\} .*'$$(date +%Y)' Free' \
> in_vc_files=$(texi) \
> halt='out of date copyright in $(texi); update it' \
> $(_sc_search_regexp)
> ===
>
> This assumes the copyright year is followed by the word "Free" (implicitly:
> "Free Software Foundation") in the texinfo file.
>
> If one is to use Gnulib on a non FSF project, "make syntax-check" fails on
> this rule.
>
> (This might be intentional, if Gnulib, or just gnulib's syntax-check, is
> assume to be used mainly on FSF projects - if so, not worth changing).
gnulib is not restricted to GNU projects:
http://git.sv.gnu.org/gitweb/?p=gnulib.git;a=blob_plain;f=users.txt;hb=HEAD
Originally that check came from coreutils.
http://git.sv.gnu.org/gitweb/?p=coreutils.git;a=commitdiff;h=9e450601
I guess it could be made more general for gnulib by just removing the " Free"
suffix.
The attached does that.
I've also seen complaints about that syntax check,
that it needs the current year on the same line as "@copyright",
so some just disable the test for their project
by adding the texi file name to .x-sc_copyright_check for example.
thanks,
Pádraig.
gnulib-copyright-check.patch
Description: Text Data