[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
hasmntopt compiler warning
From: |
Ben Walton |
Subject: |
hasmntopt compiler warning |
Date: |
Mon, 2 Jun 2014 09:38:03 +0100 |
Hi All,
When building coreutils on solaris 10 x86 with warnings as errors, the
mountlist.c code using hasmntopt complains about passing a const char
to a function expecting char. Solaris defines hasmntopt as:
char *hasmntopt(struct mnttab *, char *);
While it's easy to patch around locally, by doing:
-# define MNT_IGNORE(M) hasmntopt (M, MNTOPT_IGNORE)
+# define MNT_IGNORE(M) hasmntopt (M, (char *) MNTOPT_IGNORE)
This isn't something that is valid to send upstream. I'm not sure what
the cleanest way to handle this is. Should I simply add a conditional
logic to detect Solaris (and later other platforms) that exhibit this
mismatch or is there a better mechanism I should use?
Thanks
-Ben
--
---------------------------------------------------------------------------------------------------------------------------
Take the risk of thinking for yourself. Much more happiness,
truth, beauty and wisdom will come to you that way.
-Christopher Hitchens
---------------------------------------------------------------------------------------------------------------------------
- hasmntopt compiler warning,
Ben Walton <=