Re: error.c triggers -Wformat-extra-args

[Daniel E. Macks]

Eric Blake <address@hidden> said:
> On 06/25/2014 12:08 PM, Daniel E. Macks wrote:
>> Building gettext-0.19.1, which embeds copies of gnulib, on OS X 10.8,
>> which uses the clang compiler (via XCode-5.1), gives:
>>=20
>> clang -DHAVE_CONFIG_H -DEXEEXT=3D\"\" -I. -I..  -I../intl -I../intl -DD=
> EPENDS_ON_LIBICONV=3D1 -DDEPENDS_ON_LIBINTL=3D1  -I/sw/include  -Os -c -o=
>  error.o error.c
>> error.c:381:12: warning: data argument not used by format string [-Wfor=
> mat-extra-args]
>>            file_name, line_number);
>>            ^
>
> Thanks for the report.  In the past, we've been reluctant to silence
> warnings like this when the code is closely copied from glibc, unless
> the glibc version gets patched first.  [...]
> If you can convince glibc to clean up
> their copy first, I don't mind following suit, but for now, I'd rather
> not change this in gnulib.

I filed it with them...let's see what happens. Are you able to add
yourself to the CC list there, or I should just propagate comments
back here to the list?

https://sourceware.org/bugzilla/show_bug.cgi?id=17089

dan

-- 
Daniel Macks
address@hidden