Re: [PATCH] gettext: update macros to version 0.19

[Daiki Ueno]

Pádraig Brady <address@hidden> writes:

>   make[2]: Entering directory `/home/padraig/git/coreutils/po'
>   *** error: gettext infrastructure mismatch: using a Makefile.in.in from 
> gettext version 0.18 but the autoconf macros are from gettext version 0.19
>   make[2]: *** [check-macro-version] Error 1
>
> I can easily update gettext and can confirm 0.19 works as expected.
> Other have often expressed disdain for non readily available
> distro requiremnts like this. Should we consider reverting
> this until gettext-0.19 packages are easily available?

I feel it rather strange that bootstrap replaces m4/po.m4, already
pulled by autopoint.  As coreutils explicitly specifies the gettext
infrastructure version as 'AM_GNU_GETTEXT_VERSION([0.18.1])' in
configure.ac, IMO it should still be able to use the 0.18.1 macros even
after running bootstrap.

The file replacement happens because of some Gnulib tests depending on
the gettext module.  How about removing the dependencies?

>From c6e5277472b17de2a98e5e5c903b36efab7a039b Mon Sep 17 00:00:00 2001
From: Daiki Ueno <address@hidden>
Date: Thu, 10 Jul 2014 07:24:04 +0900
Subject: [PATCH] tests: remove dependency on gettext macros
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Some tests pulls m4/po.m4, which can be newer than the one pulled
by autopoint.  This causes problem when building packages which
request older gettext.  Problem reported by Pádraig Brady in:
http://lists.gnu.org/archive/html/bug-gnulib/2014-07/msg00023.html
* modules/utimens-tests (Depends-on): Remove gettext.
* modules/futimens-tests (Depends-on): Likewise.
* modules/quotearg-tests (Depends-on): Depend on gettext-h, not
gettext.
---
 ChangeLog              | 8 ++++++++
 modules/futimens-tests | 1 -
 modules/quotearg-tests | 2 +-
 modules/utimens-tests  | 1 -
 4 files changed, 9 insertions(+), 3 deletions(-)

diff --git a/ChangeLog b/ChangeLog
index 66fd9c8..e63ef73 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,11 @@
+2014-07-10  Daiki Ueno  <address@hidden>
+
+       tests: remove dependency on gettext macros
+       * modules/utimens-tests (Depends-on): Remove gettext.
+       * modules/futimens-tests (Depends-on): Likewise.
+       * modules/quotearg-tests (Depends-on): Depend on gettext-h, not
+       gettext.
+
 2014-07-09  Pavel Hrdina  <address@hidden> (tiny change)
 
        nl_langinfo: fix build under mingw
diff --git a/modules/futimens-tests b/modules/futimens-tests
index a1948eb..28ff826 100644
--- a/modules/futimens-tests
+++ b/modules/futimens-tests
@@ -7,7 +7,6 @@ tests/signature.h
 tests/macros.h
 
 Depends-on:
-gettext
 fcntl-h
 ignore-value
 nanosleep
diff --git a/modules/quotearg-tests b/modules/quotearg-tests
index 1af4eff..5e062a7 100644
--- a/modules/quotearg-tests
+++ b/modules/quotearg-tests
@@ -12,7 +12,7 @@ m4/locale-fr.m4
 m4/codeset.m4
 
 Depends-on:
-gettext
+gettext-h
 progname
 stdint
 setenv
diff --git a/modules/utimens-tests b/modules/utimens-tests
index 76dad1b..260c26c 100644
--- a/modules/utimens-tests
+++ b/modules/utimens-tests
@@ -9,7 +9,6 @@ tests/macros.h
 
 Depends-on:
 dup
-gettext
 ignore-value
 nanosleep
 symlink
-- 
2.0.0

Regards,
-- 
Daiki Ueno