[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: "localename" functions suggest pure/const attribute
|
From: |
Assaf Gordon |
|
Subject: |
Re: "localename" functions suggest pure/const attribute |
|
Date: |
Thu, 10 Jul 2014 14:32:33 -0400 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.6.0 |
On 07/10/2014 01:58 PM, Pádraig Brady wrote:
Oh I see now. That was more apparent from your initial patch:
http://lists.gnu.org/archive/html/bug-gnulib/2014-07/msg00038.html
(which I didn't get due to recent GNU mailing list issues).
I'll apply that.
Regarding the patch I sent,
I think the "pure" for "string_hash" is solid,
but perhaps extra review is needed for the "const" for "gl_locale_name_default"
to ensure the wrapping macros are correct.
Thanks