[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: compile warnings when including avltree-list and gcc-warnings is ena
From: |
Dylan Cali |
Subject: |
Re: compile warnings when including avltree-list and gcc-warnings is enabled |
Date: |
Sat, 6 Sep 2014 02:05:54 -0500 |
On Fri, Sep 5, 2014 at 10:51 AM, Paul Eggert <address@hidden> wrote:
> Thanks, it looks like some declarations are missing in the corresponding .h
> file, or are missing attributes that they should have. Is that something
> you could write a patch for?
Hi Paul,
Attached is a patch for the attribute and declaration warnings. After
fixing those the next warning that popped up is:
lib/gl_avltree_list.c: In function 'gl_avltree_list_check_invariants':
lib/gl_avltree_list.c:66:5: error: statement with no effect
[-Werror=unused-value]
check_invariants (list->root, NULL);
^
I'm not sure how to proceed with this one. It seems gcc is just
confused (the statement definitely has an effect as that function
aborts if the checks fail). Would it be appropriate to add a pragma
to ignore the warning for that function?
Thanks,
Dylan
fix-attr-declaration-warnings.patch
Description: Text Data
- compile warnings when including avltree-list and gcc-warnings is enabled, Dylan Cali, 2014/09/05
- Re: compile warnings when including avltree-list and gcc-warnings is enabled, Paul Eggert, 2014/09/05
- Re: compile warnings when including avltree-list and gcc-warnings is enabled, Dylan Cali, 2014/09/05
- Re: compile warnings when including avltree-list and gcc-warnings is enabled,
Dylan Cali <=
- Re: compile warnings when including avltree-list and gcc-warnings is enabled, Paul Eggert, 2014/09/06
- Re: compile warnings when including avltree-list and gcc-warnings is enabled, Dylan Cali, 2014/09/06
- Re: compile warnings when including avltree-list and gcc-warnings is enabled, Eric Blake, 2014/09/08
- Re: compile warnings when including avltree-list and gcc-warnings is enabled, Dylan Cali, 2014/09/08
- Re: compile warnings when including avltree-list and gcc-warnings is enabled, Dylan Cali, 2014/09/08
- Re: compile warnings when including avltree-list and gcc-warnings is enabled, Pádraig Brady, 2014/09/16