[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 08/21] get_shared_library_fullname: port to EMX
|
From: |
KO Myung-Hun |
|
Subject: |
Re: [PATCH 08/21] get_shared_library_fullname: port to EMX |
|
Date: |
Tue, 02 Dec 2014 14:49:18 +0900 |
|
User-agent: |
Mozilla/5.0 (OS/2; Warp 4.5; rv:10.0.6esrpre) Gecko/20120715 Firefox/10.0.6esrpre SeaMonkey/2.7.2 |
Hi/2.
Sorry, I missed this comment.
Bruno Haible wrote:
>> +#ifdef __EMX__
>> +# define INCL_DOS
>> +# include <os2.h>
>> +
>> +#define strcmp stricmp
>> +#define strncmp strnicmp
>> +#endif
>
> Please indent these lines:
> # define strcmp stricmp
> # define strncmp strnicmp
>
Fixed.
>> + if (DosQueryModuleName (hModule, sizeof (location), location))
>
> Can you add a comment with the URL of the specification of the
> DosQueryModuleName function (if possible), please?
>
See
http://cyberkinetica.homeunix.net/os2tk45/cp1/1247_L2H_DosQueryModuleNameSy.html
--
KO Myung-Hun
Using Mozilla SeaMonkey 2.7.2
Under OS/2 Warp 4 for Korean with FixPak #15
In VirtualBox v4.1.32 on Intel Core i7-3615QM 2.30GHz with 8GB RAM
Korean OS/2 User Community : http://www.ecomstation.co.kr
0001-get_shared_library_fullname-port-to-EMX.patch
Description: Text document