bug-gnulib
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[PATCH 1/2] diffseq: prefer ptrdiff_t to ssize_t


From: Paul Eggert
Subject: [PATCH 1/2] diffseq: prefer ptrdiff_t to ssize_t
Date: Sat, 7 Feb 2015 18:10:13 -0800

* lib/diffseq.h: In commentary, prefer ptrdiff_t to ssize_t.
ptrdiff_t is the natural type for signed indexes.
On a few older platforms, ssize_t is narrower than size_t.
---
 ChangeLog     | 5 +++++
 lib/diffseq.h | 4 ++--
 2 files changed, 7 insertions(+), 2 deletions(-)

diff --git a/ChangeLog b/ChangeLog
index 774903e..3207028 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,5 +1,10 @@
 2015-02-07  Paul Eggert  <address@hidden>
 
+       diffseq: prefer ptrdiff_t to ssize_t
+       * lib/diffseq.h: In commentary, prefer ptrdiff_t to ssize_t.
+       ptrdiff_t is the natural type for signed indexes.
+       On a few older platforms, ssize_t is narrower than size_t.
+
        xalloc: fix typo that suppressed warnings
        * lib/xalloc.h: Add missing _GL_INLINE_HEADER_END.
        This typo, introduced a couple of years ago, mistakenly suppressed
diff --git a/lib/diffseq.h b/lib/diffseq.h
index b418830..a4f389a 100644
--- a/lib/diffseq.h
+++ b/lib/diffseq.h
@@ -41,8 +41,8 @@
      EQUAL                   A two-argument macro that tests two elements for
                              equality.
      OFFSET                  A signed integer type sufficient to hold the
-                             difference between two indices. Usually
-                             something like ssize_t.
+                             difference between two indices.  Usually
+                             something like ptrdiff_t.
      EXTRA_CONTEXT_FIELDS    Declarations of fields for 'struct context'.
      NOTE_DELETE(ctxt, xoff) Record the removal of the object xvec[xoff].
      NOTE_INSERT(ctxt, yoff) Record the insertion of the object yvec[yoff].
-- 
2.1.0




reply via email to

[Prev in Thread] Current Thread [Next in Thread]