[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] fts: fix a crash triggered by recursive bind mount
|
From: |
Pádraig Brady |
|
Subject: |
Re: [PATCH] fts: fix a crash triggered by recursive bind mount |
|
Date: |
Wed, 11 Feb 2015 17:11:00 +0000 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 |
On 11/02/15 15:36, Kamil Dudka wrote:
> Reported by Michael Chapman in: https://bugzilla.redhat.com/1188498
> * lib/fts.c (fts_read): Avoid removing the original hash table item
> when leaving a directory that caused a cycle, and preserve the FTS_DC
> flag.
This looks good to me on first glance.
Is it due to a race, when the cycle is added while traversing?
If it is a race that should be mentioned in the commit summary.
thanks!
Pádraig