Re: [PATCH 00/11] Android compatibility

[Paul Eggert]

Thanks for doing all that work!  I pushed the first 10 patches and have
a couple of comments.  I'll send a separate email about the 11th patch.

Kevin Cernekee wrote:

> FAIL: test-verify.sh
> ====================
>
> compiler didn't detect verification failure 1
> ...
> test-verify is trying to perform compile-time checks.  Since I didn't
> rebuild NDK to run natively on the ARM target, this failure is expected.

I'm still puzzled by this failure.  If there's no native compiler, then when 
test-verify.sh calls 'make', 'make' should try to compile and this compilation 
should fail, so test-verify.sh should think that the compiler correctly failed 
(presumably after reporting the verification failure).  Why didn't that happen 
for you?

> test-localename is calling strdup() on a NULL pointer returned by
> gl_locale_name_thread(), and crashing.  From reading
> gl_locale_name_thread() it seems like NULL is a valid result.  Maybe we
> need to change the test case to "return 77" on systems that are unaware
> of locales?

Yes, that sounds right.  Can you propose a patch along those lines?