syncing regcomp.c with glibc, or further diverging, or applying patches separately.

[Konstantin Serebryany]

Hello,

[I've been routed here from address@hidden

There is a discussion on the GLIBC mailing list regarding a non-trivial change
in GLIBC's regcomp.c: a complete removal of nested functions.
https://sourceware.org/ml/libc-alpha/2014-09/msg00663.html

Carlos says: The first step is to synchronize this file with gnulib.

The current diff between GLIBC's and Gnulib's variants is over 1K lines,
so synchronizing does not sounds trivial.

Judging by git log, some of the patches are simply applied to both
variants independently,
e.g.
Glibc commit 4d43ef1e7434d7d419afbcd754931cb0c794763c
Gnulib commit 316c9c508c315504b55c935ffd409b60135f918e

But some patches are not applied to Gnulib:
e.g. in Glibc's commit 39a12f8db4656bec88ebd51e524778ef2e5468b9 or
8c0ab919f63dc03a420751172602a52d2bea59a8

Do you have a suggestion regarding the patch discussed in
https://sourceware.org/ml/libc-alpha/2014-09/msg00663.html?
The patch does not lead to a functionality change, but affects the
sources significantly (560 line diff)

Is that ok to apply it only to Glibc?
Or would you like to have it for Gnulib too?
(This will be non-trivial amount of work)

Thanks,

--kcc