[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [GNULIB 4/4] qacl: Reimplement qset_acl and qcopy_acl
From: |
Tom G. Christensen |
Subject: |
Re: [GNULIB 4/4] qacl: Reimplement qset_acl and qcopy_acl |
Date: |
Fri, 29 May 2015 18:48:58 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 |
On 15/04/15 22:12, Andreas Grünbacher wrote:
Alright. The qsetacl and qcopy_acl rewrite needs some testing on
non-Linux platforms; there may be some glitches there.
Indeed.
I just noticed that my daily builds on Solaris 9 (and earlier) are
broken due to this change.
gcc -DHAVE_CONFIG_H -I. -I.. -DGNULIB_STRICT_CHECKING=1 -D_REENTRANT
-g -O2 -MT set-permissions.o -MD -MP -MF $depbase.Tpo -c -o
set-permissions.o set-permissions.c &&\
mv -f $depbase.Tpo $depbase.Po
set-permissions.c: In function 'set_acls':
set-permissions.c:614:28: error: 'count' undeclared (first use in this
function)
ret = facl (desc, SETACL, count, entries);
^
set-permissions.c:614:28: note: each undeclared identifier is reported
only once for each function it appears in
set-permissions.c:614:35: error: 'entries' undeclared (first use in this
function)
ret = facl (desc, SETACL, count, entries);
^
make[4]: *** [set-permissions.o] Error 1
It looks like a trivial error where count and entries and later
ace_count and ace_entries should really be referring to the
permission_context struct with ctx->.
Such a change at least builds and passes the testsuite for me.
-tgc
- Re: [GNULIB 4/4] qacl: Reimplement qset_acl and qcopy_acl,
Tom G. Christensen <=