[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Dead code in hol_entry_help
|
From: |
Andrei Borzenkov |
|
Subject: |
Re: Dead code in hol_entry_help |
|
Date: |
Mon, 11 Jan 2016 10:14:45 +0300 |
On Mon, Jan 11, 2016 at 9:56 AM, Paul Eggert <address@hidden> wrote:
> Andrei Borzenkov wrote:
>>
>> It looks like assignment to first_long_opt is
>> missing somewhere.
>
>
> It seems to have been missing ever since it was added.
>
> I assume that both bugs you mentioned don't occur in glibc. Perhaps all we
> need to do is to merge glibc's argp changes into gnulib. Attached is a first
> cut at doing that, though it still needs work (I've probably botched some of
> the merge).
It looks like it fixes both problems (and as far as I can tell, some
more NULL dereferences of state variable).