|
| From: | Paul Eggert |
| Subject: | Re: [PATCH v7 08/11] openat_proc_name: port to OS/2 kLIBC |
| Date: | Thu, 14 Jan 2016 13:55:19 -0800 |
| User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.0 |
On 01/13/2016 06:23 PM, KO Myung-Hun wrote:
+ if (__libc_Back_ioFHToPath (fd, path, sizeof (path)))
Don't parenthesize the argument of sizeof here.
+ sprintf (result, "%s/%s", path, file);
This won't work if PATH or FILE is longer than INT_MAX bytes. Please just use memcpy or strcpy instead.
| [Prev in Thread] | Current Thread | [Next in Thread] |