bug-gnulib
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] wcwidth: check a macro version of wcwidth () as well


From: Bruno Haible
Subject: Re: [PATCH] wcwidth: check a macro version of wcwidth () as well
Date: Fri, 06 Oct 2017 19:26:47 +0200
User-agent: KMail/5.1.3 (Linux/4.4.0-96-generic; KDE/5.18.0; x86_64; ; )

Hi,

KO Myung-Hun wrote:
> Check the functionality of a macro version wcwidth () as well as a
> real function.
> 
> This is better than undefining wcwidth on OS/2 kLIBC without functional
> check.

With your patch, does the following command sequence pass its tests?

  $ ./gnulib-tool --create-testdir --dir=testdir1 --single-configure 
--with-c++-tests wcwidth
  $ cd testdir1
  $ ./configure
  $ make
  $ make check

> +    gl_cv_func_wcwidth_macro,
> ...
> +       gl_cv_func_wcwidth_macro=yes,
> +       gl_cv_func_wcwidth_macro=no)])

In gnulib, for a long time, we use "quote all m4 macro arguments through 
brackets"
coding style. Just a matter of consistent coding style (that makes our Autoconf
macros halfway readable).

Bruno




reply via email to

[Prev in Thread] Current Thread [Next in Thread]