bug-gnulib
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] wcwidth: check a macro version of wcwidth () as well


From: KO Myung-Hun
Subject: Re: [PATCH] wcwidth: check a macro version of wcwidth () as well
Date: Sat, 07 Oct 2017 13:09:26 +0900
User-agent: Mozilla/5.0 (OS/2; Warp 4.5; rv:10.0.6esrpre) Gecko/20120715 Firefox/10.0.6esrpre SeaMonkey/2.7.2

Hi/2.

Bruno Haible wrote:
> Hi,
> 
> KO Myung-Hun wrote:
>> Check the functionality of a macro version wcwidth () as well as a
>> real function.
>>
>> This is better than undefining wcwidth on OS/2 kLIBC without functional
>> check.
> 
> With your patch, does the following command sequence pass its tests?
> 
>   $ ./gnulib-tool --create-testdir --dir=testdir1 --single-configure 
> --with-c++-tests wcwidth
>   $ cd testdir1
>   $ ./configure
>   $ make
>   $ make check
> 

I attach test-suite.log.

>> +    gl_cv_func_wcwidth_macro,
>> ...
>> +       gl_cv_func_wcwidth_macro=yes,
>> +       gl_cv_func_wcwidth_macro=no)])
> 
> In gnulib, for a long time, we use "quote all m4 macro arguments through 
> brackets"
> coding style. Just a matter of consistent coding style (that makes our 
> Autoconf
> macros halfway readable).
> 

Fixed. And I increased serial number by 1.

-- 
KO Myung-Hun

Using Mozilla SeaMonkey 2.7.2
Under OS/2 Warp 4 for Korean with FixPak #15
In VirtualBox v4.1.32 on Intel Core i7-3615QM 2.30GHz with 8GB RAM

Korean OS/2 User Community : http://www.os2.kr/

Attachment: test-suite.log
Description: Text document

Attachment: 0001-wcwidth-check-a-macro-version-of-wcwidth-as-well.patch
Description: Source code patch


reply via email to

[Prev in Thread] Current Thread [Next in Thread]