[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [V2 PATCH] Implement SM3 hash algorithm in gnulib and the computing
|
From: |
Bruno Haible |
|
Subject: |
Re: [V2 PATCH] Implement SM3 hash algorithm in gnulib and the computing tool in coreutils. |
|
Date: |
Sat, 28 Oct 2017 15:09:06 +0200 |
|
User-agent: |
KMail/5.1.3 (Linux/4.4.0-97-generic; KDE/5.18.0; x86_64; ; ) |
Jia Zhang wrote:
> > gcc: error: @LIB_CRYPTO@: No such file or directory
>
> Thanks for your comments. I fixed it and the test passes. I just feel
> strange that test-sm3 was built out without error if I compiled gnulib
> with coreutils together.
It passed with coreutils because coreutils requests other crypto modules
as well, and these set LIB_CRYPTO.
The particular thing about Gnulib is that people can use an *arbitrary
subset* of its set of modules. Therefore, when we add a module we must
make sure that
1. the module works standalone, without any other modules,
2. conflicts with other modules are avoided.
'gnulib-tool --create-testdir' is the tool for verifying this.
Bruno