Re: pygnulib: progress and some questions (func_emit_autoconf_snippets)

[Dmitry Selyutin]

Hi Bruno,

thank you for the detailed answer. I think I still have to do some debugging to understand why the Python version of the algorithm for autoconf snippets generation works incorrectly, but I hope I understood how it should work.

29 дек. 2017 г. 2:32 ДП пользователь "Bruno Haible" <address@hidden> написал:

Hi Dmitry,

> > 1. At line 4260, what's the place where $modules variable gets assigned?
>
> Indeed the comments for function func_emit_autoconf_snippets are misleading:
> This functions receives two module lists:
>   $modules (implicit),
>   $1 (explicit: first argument).
>
> Where does $modules come from?
>   - For the invocation in func_import, line 5640 and 5659
>     it is set at line 5298. But I'm not sure this was intended this way, maybe
>     another list should be used instead of "$main_modules"?
>   - For the invocation in func_create_testdir, line 6288 and 6290 and 6402 and 6404 and 6417
>     it does not appear to be set in a consistent and correct way.
>     (It is set differently if $single_configure and ! $single_configure.)
>     This is probably a bug.
> The set of modules that _ought_ to be used here is the set of modules
> being used for the current configure file. That's my current understanding.
> But I'd really need to look at a couple of test cases in order to
> firmly answer the question.

I've understood it now: the code in func_create_testdir was not really a bug,
because --conditional-dependencies was not allowed in this case anyway.

Here's the patch that implements --conditional-dependencies also with
--with-tests.

Bruno