[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: -Wundef in *.h [was: [PATCH v2] stat-time: silence -Wunused-paramete
From: |
Tim Rühsen |
Subject: |
Re: -Wundef in *.h [was: [PATCH v2] stat-time: silence -Wunused-parameter regression] |
Date: |
Thu, 4 Jan 2018 10:45:12 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.2 |
On 01/03/2018 10:29 PM, Eric Blake wrote:
> We still use ChangeLog-style comments in the commit message (and/or
> ChangeLog itself) for gnulib commits; it's also nice to call out which
> previous commit to cdefs.h already added protection for -Wundef
> compilation. But with those additions, I'm okay with your patch; I'll
> wait a day or so to see if anyone else chimes in.
Added GNU style commit message, unsure what you mean with "which
previous commit to cdefs.h already added protection for -Wundef".
Can't find any (from commit messages).
Regards, Tim
0001-Fix-Wundef-in-user-included-header-lib-cdef.h.patch
Description: Text Data
signature.asc
Description: OpenPGP digital signature
- Re: [PATCH] Avoid one "parameter unused" warnings., (continued)
- Re: [PATCH] Avoid one "parameter unused" warnings., Eric Blake, 2018/01/02
- [PATCH v2] stat-time: silence -Wunused-parameter regression, Eric Blake, 2018/01/02
- Re: [PATCH v2] stat-time: silence -Wunused-parameter regression, Jim Meyering, 2018/01/02
- Re: [PATCH v2] stat-time: silence -Wunused-parameter regression, Paul Eggert, 2018/01/02
- Re: [PATCH v2] stat-time: silence -Wunused-parameter regression, Tim Rühsen, 2018/01/03
- -Wundef in *.h [was: [PATCH v2] stat-time: silence -Wunused-parameter regression], Eric Blake, 2018/01/03
- Re: -Wundef in *.h [was: [PATCH v2] stat-time: silence -Wunused-parameter regression], Tim Rühsen, 2018/01/03
- Re: -Wundef in *.h [was: [PATCH v2] stat-time: silence -Wunused-parameter regression], Eric Blake, 2018/01/03
- Re: -Wundef in *.h [was: [PATCH v2] stat-time: silence -Wunused-parameter regression], Paul Eggert, 2018/01/03
- Re: -Wundef in *.h [was: [PATCH v2] stat-time: silence -Wunused-parameter regression],
Tim Rühsen <=
- Re: -Wundef in *.h [was: [PATCH v2] stat-time: silence -Wunused-parameter regression], Bruno Haible, 2018/01/04
- Re: -Wundef in *.h [was: [PATCH v2] stat-time: silence -Wunused-parameter regression], Eric Blake, 2018/01/04
- Re: -Wundef in *.h [was: [PATCH v2] stat-time: silence -Wunused-parameter regression], Tim Rühsen, 2018/01/04
Re: [PATCH] Avoid one "parameter unused" warnings., Bruno Haible, 2018/01/01