Re: [PATCH] build: GuixSD doesn't have /bin/bash.

[Mathieu Lirzin]

Paul Eggert <address@hidden> writes:

> On 01/22/2018 01:14 PM, Mathieu Lirzin wrote:
>> -SHELL=/bin/bash
>> +SHELL=bash
>
> Historically $(SHELL) needed to be absolute, so that it could be put
> into the #! lines at the start of script. Does this ever happen with
> Gnulib?

I don't think, since ‘grep -r '^#! *\$'’ doesn't bring any results.

> If so, we need a better solution than that.

Considering the requirements of having an absolute filename and not
being able to reliably guess that filename, it seems that we should
either use ‘which’ or add a configure phase to generate the Makefile
with the correct SHELL variable.

Using ‘which’ would have the drawback of adding another dependency to
the build process.  OTOH Having a configure script allows other
prerequisites such as GNU Make, ‘git’, ‘makeinfo’ and ‘cppi’ to be
checked explicitly which would be an improvement.  Maybe there is a good
reason I am overlooking that explains why Gnulib doesn't already have a
configure script.

-- 
Mathieu Lirzin
GPG: F2A3 8D7E EB2B 6640 5761  070D 0ADE E100 9460 4D37