Re: [PATCH 5/6] fts: three levels of leaf optimization

[Kamil Dudka]

On Wednesday, April 11, 2018 3:38:40 PM CEST James Youngman wrote:
> On Thu, Apr 5, 2018 at 4:49 PM, Paul Eggert <address@hidden> wrote:
> > On 04/05/2018 05:44 AM, Kamil Dudka wrote:
> >> Does this change (intentionally?) enable leaf optimization for CIFS?
> > 
> > No, I wasn't thinking about CIFS when I wrote that. Thanks for reporting
> 
> it. I installed the attached to try to fix this. I have not tested it with
> CIFS.
> 
> 
> Where is the abort actually happening?   If the abort is in fts itself,
> then this patch is a reasonable fix (though generally I prefer not to allow
> aborts in library code).   But if the abort is in find itself (i.e. not in
> the gnulib code at all) then we should fix find (either as well, or
> instead).
> 
> James.

The abort() is in gnulib/fts code.  It is triggered on this line:

http://git.savannah.gnu.org/gitweb/?p=gnulib.git;a=blob;f=lib/fts.c;h=3814e58f#l1383

As far as I know, there is currently no fix available for that.

Kamil