[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH V2] localcharset: short-circuit the search for an alias on a
|
From: |
Benno Schulenberg |
|
Subject: |
Re: [PATCH V2] localcharset: short-circuit the search for an alias on a Mac |
|
Date: |
Sat, 21 Apr 2018 13:23:53 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 |
Hi Bruno,
Op 21-04-18 om 12:41 schreef Bruno Haible:
> Thanks, applied.
(For some background: a bug reporter found that on a Mac lots of
time would be spent in locale_charset() when nano called wcwidth():
https://savannah.gnu.org/bugs/?53562#comment16.)
> I added a comment.
> Explanations about the code belong in the code, as comments, IMO.
> Readers of the code should not be forced to constantly refer to
> ChangeLog entries and commit messages in order to understand the code.
True. Much better this way. Thanks.
Benno