[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: bug#31439: [PATCH] fts: avoid a memory leak edge case
|
From: |
Pádraig Brady |
|
Subject: |
Re: bug#31439: [PATCH] fts: avoid a memory leak edge case |
|
Date: |
Mon, 14 May 2018 02:14:01 -0700 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 |
On 14/05/18 01:28, Bruno Haible wrote:
> Kamil Dudka wrote:
>> Why are you removing fflush (stdout) from the test without any explanation?
>
> Yes, fflush(stdout) statements are extremely important if you want to
> understand/debug test failures on native Windows.
Oops, I wasn't aware of windows considerations.
I didn't actually see where there was any output to stdout
in this test, and I thought fflush() was therefore redundant?
More problematically could impinge on the previous fts_read() errno?
Should save the errno from fts_read?
Should I perror() any errno from fflush?
cheers,
Pádraig