bug-gnulib
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

avoid FP syntax-check failure due to bootstrap


From: Jim Meyering
Subject: avoid FP syntax-check failure due to bootstrap
Date: Sat, 30 Jun 2018 21:13:02 -0700

I copied the latest bootstrap into gzip's top level directory to
update the copy we version-control there, and ran "make syntax-check".
It failed due to the false-positive match on several lines in bootstrap
that look like option names with only one space between the "--option"
and the following description. In fact, the thing following each is
not a description but rather the option argument. Since gnulib-tool
is perfectly happy with the IMHO-preferable "--option=arg" syntax,
I propose to do the following:

[An alternative would be to exempt bootstrap from that particular
syntax-check rule, albeit having to do that in at least a few other
projects.]

>From 3517bf807ade06d070d410cd2f8986603cb2f876 Mon Sep 17 00:00:00 2001
From: Jim Meyering <address@hidden>
Date: Sat, 30 Jun 2018 19:57:07 -0700
Subject: [PATCH] bootstrap: s/--option val/--option=val/

* build-aux/bootstrap (gnulib_tool_options): Change the
spelling of "--option val" pairs to "--option=val", for
aesthetics, and also so that this file no longer triggers
a common help2man syntax-check warning when copied into
projects like grep, gzip, etc.
---
 ChangeLog           |  9 +++++++++
 build-aux/bootstrap | 16 ++++++++--------
 2 files changed, 17 insertions(+), 8 deletions(-)

diff --git a/ChangeLog b/ChangeLog
index e25f5a7d6..02ba6b3e3 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,12 @@
+2018-06-30  Jim Meyering  <address@hidden>
+
+       bootstrap: s/--option val/--option=val/
+       * build-aux/bootstrap (gnulib_tool_options): Change the
+       spelling of "--option val" pairs to "--option=val", for
+       aesthetics, and also so that this file no longer triggers
+       a common help2man syntax-check warning when copied into
+       projects like grep, gzip, etc.
+
 2018-06-30  Paul Eggert  <address@hidden>

        regex: trim module dependencies
diff --git a/build-aux/bootstrap b/build-aux/bootstrap
index 002edf68d..ed3b0a4b7 100755
--- a/build-aux/bootstrap
+++ b/build-aux/bootstrap
@@ -1,6 +1,6 @@
 #! /bin/sh
 # Print a version string.
-scriptversion=2018-05-27.20; # UTC
+scriptversion=2018-07-01.02; # UTC

 # Bootstrap this package from checked-out sources.

@@ -942,13 +942,13 @@ fi
 if $use_gnulib; then
   gnulib_tool_options="\
    --no-changelog\
-   --aux-dir $build_aux\
-   --doc-base $doc_base\
-   --lib $gnulib_name\
-   --m4-base $m4_base/\
-   --source-base $source_base/\
-   --tests-base $tests_base\
-   --local-dir $local_gl_dir\
+   --aux-dir=$build_aux\
+   --doc-base=$doc_base\
+   --lib=$gnulib_name\
+   --m4-base=$m4_base/\
+   --source-base=$source_base/\
+   --tests-base=$tests_base\
+   --local-dir=$local_gl_dir\
    $gnulib_tool_option_extras\
   "
   if test $use_libtool = 1; then
--
2.18.0



reply via email to

[Prev in Thread] Current Thread [Next in Thread]