bug-gnulib
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] Add renameat2 function [BZ #17662]


From: Florian Weimer
Subject: Re: [PATCH] Add renameat2 function [BZ #17662]
Date: Wed, 4 Jul 2018 22:26:41 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0

On 07/04/2018 10:13 PM, Carlos O'Donell wrote:
This is a good suggestion, and I think Florian should work on something
going into the manual to document the behaviour.

We do not have any documentation for the *at functions at present. I find it difficult to document renameat2 without reference to openat and a generic description of the AT_* flags. I feel this is something we should tackle after the release.

Once the patch is in, I will propose something for the existing manual page, documenting the EINVAL behavior of the glibc wrapper and the existence of the gnulib implementation.

You position Gnulib's implementation as having no drawbacks, but this
is not true. The API has a race, and it is something which along with
other similar racy APIs has caused difficult to solve problems a the
distribution level.

And as Joseph pointed out, there is a different emulation strategy with a different failure mode (use link and potentially leave behind a hard-linked file under both names).

Thanks,
Florian



reply via email to

[Prev in Thread] Current Thread [Next in Thread]